Personally I'd keep it as a wrapper script. There are no shell
compatibility issues because it would still be svnserve.exe on Win32.
AFAIK, this only affects *nix, so only *nix would get the wrapper script.
If it is a script, then it can also be easily modified for specific cases.
If it is built into the code, then it is much harder to change. What if
someone wanted a different umask or wanted to add some extra commands to the
script?
A wrapper script is transparent to the end-user and mostly transparent to
the repos admin.
Sly
Leeuw van der, Tim wrote:
> Hi,
>
> This sounds to me, as a layman user, as a very good solution because
> it avoids shellscript compatibility problems between Unix and
> Windows, and puts such problems on a level (the C code) where the
> user doesn't see it).
>
> with regards,
>
> --Tim
>
> -----Original Message-----
> From: junkio@cox.net [mailto:junkio@cox.net]
> Sent: vrijdag 22 augustus 2003 8:35
> To: cmpilato@collab.net
> Cc: Steve Williams; Michael Wood; users@subversion.tigris.org
> Subject: Re: need help setting up svn+ssh://
>
>
>>>>>> "cmpilato" == cmpilato <cmpilato@collab.net> writes:
>
> cmpilato> "Steve Williams" <stevewilliams@kromestudios.com> writes:
>>> Does using the umask hack adversely affect a non-SSH or inetd
>>> svnserve process? If not, then it wouldn't hurt to use it. If it
>>> would affect them, then I'm not sure what would be done.
>
> cmpilato> That's good question to ask. If we agree that it's safe in
> all cmpilato> circumstances to use the script, it would make sense to
> ship and cmpilato> install the script with the svnserve process.
>
> If so maybe calling umask(2) directly at the beginning of
> svnserve binary, instead of shipping a wrapper, would be
> cleaner. Better yet, do it with a command line switch perhaps,
> so that situations that need it (e.g. svn+ssh) can turn it on?
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org
Received on Fri Aug 22 10:11:22 2003