[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Win 10 Explorer Crash with Double Delete Running

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Mon, 27 Feb 2017 22:38:38 +0100

On 27.02.2017 01:38, Stephen L. De Rudder wrote:
> Better call stack:
> TortoiseSVN.dll!__report_gsfailure(unsigned __int64 stack_cookie) Line 199 C
> TortoiseSVN.dll!CRemoteCacheLink::CloseCommandPipe() Line 155 C++
> TortoiseSVN.dll!CRemoteCacheLink::ReleaseLockForPath(const CTSVNPath & path) Line 276 C++
> TortoiseSVN.dll!CShellExt::CopyCallback_Wrap(HWND__ * wFunc, unsigned int pszSrcFile, unsigned int) Line 317 C++
> TortoiseSVN.dll!CShellExt::CopyCallback(HWND__ * hWnd, unsigned int wFunc, unsigned int wFlags, const wchar_t * pszSrcFile, unsigned long dwSrcAttribs, const wchar_t * pszDestFile, unsigned long dwDestAttribs) Line 299 C++

Thanks!

Looking through the code I can't find anything wrong with it.
The exception you get is
Unhandled exception at 0x0000000075F2B8BC (TortoiseSVN.dll) in
explorer.exe: Stack cookie instrumentation code detected a stack-based
buffer overrun.

which means somewhere the stack is corrupted. But I can't see where that
would happen in the TSVN shell extension.
Also, all critical paths are guarded with critical section objects.

Problem is that the stack cookie instrumentation exception is thrown at
times when the stack is checked. But that doesn't mean that the stack is
corrupted where that check is done but can be corrupted way before that.
So maybe another shell extension corrupts the stack?

I'm trying to reproduce the problem on my machine, but so far no luck,
i.e. I get no crash.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3214370
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2017-02-27 22:38:49 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.