Re: post-update hook not executed after checkout?

On 17.09.2014 08:29, Schnyder Franz wrote:
> Hi
>
> Just around the time you posted this we encountered the same problem because we started using the post update hook. So we waited eager for an answer. Since nothing happened I had a look into the code yesterday. I think I found the problem and have a patch which fixes it but I'm not sure that it does not introduce any side effects since a just had a quick look and do not have an overview of the hole code base and functionality.
>
> I think the problem is that the the ProjectProperties are read/parsed at the start-up:
>
> UINT CSVNProgressDlg::ProgressThread()
> {
> ...
> if (!m_ProjectProperties.PropsRead())
> {
> m_ProjectProperties.ReadPropsPathList(m_targetPathList);
> }
> ...
> }
>
> But since we have nothing local yet when doing a checkout the ProjectProperties are empty. Then after the checkout the hooks are executed but since the ProjectProperties are empty no hook is executed.
> So in my patch blow I redo the ProjectProperties reading/parsing after the checkout but before the hooks are executed and now the ProjectProperties contain the post-update hook and it is executed.
>
> It would be nice if a commiter could have a look at the patch below to judge and maybe include it into the code base or should a create a bug and attach the patch to the bug?
>

Thanks for the patch, but that's the wrong place to do this.
See this one:
https://code.google.com/p/tortoisesvn/source/detail?r=25855

I think that's better...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3088643
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].