[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Feature request: add a cancel button to RepoBrowser window

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 11 Jun 2014 15:10:48 +0200

On 10.06.2014 15:00, Benjamin wrote:
> Yes, that's the point and I also wonder why the thread that populates
> the repository browser treeview needs to hide the Cancel button once
> again after it has completed its job, despite the button has already
> been hidden within the CRepositoryBrowser::OnInitDialog() call (which
> happens before the thread is started). If I am not wrong, the
> CRepositoryBrowser::DoModal() call induces the
> CRepositoryBrowser::OnInitDialog() call by the framework. At this
> moment, the "stand-alone" mode choice cannot be changed anymore by
> the caller (because it is currently blocked within the DoModal()
> call). What do you think?

The OnInitDialog() is called from DoModal(), that's correct.
But the log dialog is also started as a non-modal dialog in various
places, and there the order of the method execution is different.
That's why the thread also hides the button.

> Concerning the nightlybuilds: Thanks for the explanation. FYI, I
> first tried the
> http://nightlybuilds.tortoisesvn.net/latest/win32/full/TortoiseSVN-1.8.99.25556-dev-win32-svn-1.8.x-dev.msi
> version but I received an "Invalid Win32 application" from Windows
> when trying to start TortoiseProc.exe. I was still investigating if
> it is not due to an error on my side before bothering you.

verify the digital signature on the msi file to make sure the file is
not changed or corrupt. If you don't see a digital signature in the
explorer properties tab of the msi file, then download it again
(the digital signature of the nightly builds is from WANdisco, not from
me - but it's still digitally signed).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3083107
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2014-06-11 15:10:36 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.