Re: Commit dialog repeated when commit itself succeds but updating WC fails

On 16.05.2014 17:24, Niemann, Hartmut wrote:
> Hello!
>
> If a commit fails due to a server-side problem, the commit
>
> restarts (files remain checked/unchecked, commit message remains), which
> is very useful.
>
> Our server tends to produce SSL connection failures (way too often, but
>
> this is a different problem).
>
> I observed that there seem to be two distinct accesses to the server,
> one for the commit
>
> and one that seems to update the working copy.
>
> I saw the commit access succeed (Commit number is displayed)
>
> but the second access fail (with the SSL communication problem).
>
> I could see via our server’s web interface that the changes were truly
> committed.
>
> Then TortoiseSVN tries to repeat the commit (reopens the commit dialog),
> which seems to be wrong in this case,
>
> because the changes are already committed.
>
> The right thing to do seems to be to repeat the update only. (I updated
> by hand and TSVN merged
>
> the changes, which was trivial because server and wc content was identical.)
>
> Am I missing anything?
>
> Is TSVNs behavior correct, or would it be possible / better to
> differentiate whether the
>
> commit part or the update-wc part failed?
>
> (Tortoise SVN 1.8.6 on Win7)

The problem here is that the client does not know at what stage the
error happened, only that the commit could not finish properly.

What happens here is basically this:
1. client sends commit data
2. server saves the commit
3. server tells client that commit finished
4. client waits for the 'ok' from the server

Between 3 and 4, the 'ok' message does not get sent but there's a
network error happening.

There's no way for the client to know if the commit finished or not,
only that there was an error in the communication. But whether the
server tried to send an error indicating that the commit did not get
through, or whether it tried to send an 'ok' is unknown.

So there's no way for TSVN to know that it just has to do an update
instead or re-trying the commit.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3078519
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].