[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in diff-dll.vbs. Filename with space will always be reported as identical.

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 29 Apr 2014 19:34:54 +0200

On 29.04.2014 00:47, Chung Wong wrote:
> Hi,
>
> I would like to report a bug. When I do TSVN Diff on a dll file that has
> space in its filename, it will always be reported as identical even
> though it has been changed. The problem is on line 57 of the
> diff-dll.vbs script:
>
> exitStatus = WshShell.Run("fc.exe "+sBaseDoc+" "+sNewDoc, 0, True)
>
> It should have been:
>
> exitStatus = WshShell.Run("fc.exe /b """+sBaseDoc+""" """+sNewDoc+"""",
> 0, True)
>
> The extra quotes are needed to handle the space in the filename
> correctly. Not sure the “/b” is necessary but it shouldn’t hurt.
>
> Thanks for making TSVN such a great tool to use!

Thanks for the change.
Committed in r25462.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3077263
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2014-04-29 19:34:47 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.