Re: Issues with Excel diff in Tortoise-1.7.12

Hello,

Please find "other problem" example I've attached.
When diff lhs.xlsx and rhs.xlsx, r23920 (TortoiseSVN 1.7.12's diff script) works fine.
But r24102 marks everything is different.

Best regards,

-- 
Nazy: Hiroki Najima
(2013/04/21 1:46), Hiroki NAJIMA wrote:
> Dear Stefan Küng and George Stein,
>
> Thanks for report the bug and fix it.
> Actually, I don't agree r24102 because it causes other problem though.
> I want to solve it completely, so, please provide me the file which face to the problem.
> I know r24102 trick because which was available in the original script.
> Howerver, I could not reproduce any problem which the trick works, so I intentionally removed it.
>
> The bad point of the solution is it supporse to “A1” cell always can be overwritten.
> But the assumption sometime does not true.
> For example, an excel file has Auto Filter (Excel 2003 or earlier) or Table (Excel 2007 or later)
> and the cell "A1" is the table header, A1 could not be overwritten.
> That is one of my motivation I’ve create new excel diff script.
>
> Best regards,
> --
> Nazy: Hiroki Najima
>
> (2013/04/13 3:03), Stefan Küng wrote:
>> On 11.04.2013 11:52, George Stein wrote:
>>> We found two issues when diffing Excel spreadsheets with TortoiseSVN-1.7.12
>>>
>>> First, an upgrade from earlier TortoiseSVN versions doesn't change the default settings from former diff-xls.vbs to new diff-xls.js script.
>>>
>>> Second, executing a diff leads to a Windows script host error message:
>>> Script: C:\Program Files\TortoiseSVN\Diff-Scripts\diff-xls.js
>>> Line: 147
>>> Char: 9
>>> Error: Invalid procedure call or argument
>>> Code: 800A0005
>>> Source: Microsoft JScript runtime error
>>>
>>> With the latest version from http://tortoisesvn.googlecode.com/svn/branches/1.7.x/contrib/diff-scripts/diff-xls.js, r24094 the error message changes only in
>>> ...
>>> Line: 178
>>> ...
>>>
>>> Tested with Microsoft Excel 2010 (14.0.6129.5000) in Windows7 and Windows XP.
>>
>> Fixed in r24102.
>>
>> Stefan
>>
>
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3053861
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].