Re: Commit Dialog: Double click to "Compare with base" does not work

On 31.10.2011 10:51, Evgeny wrote:
> A little research revealed the following check in the
> SVNStatusListCtrl.cpp, lines 3701-3704 (function
> CSVNStatusListCtrl::OnNMDblclk):
>
> UINT hitFlags = 0; HitTest(pNMLV->ptAction,&hitFlags); if (hitFlags&
> LVHT_ONITEMSTATEICON) return;
>
> I made a small test program that logs hit-test flags in the
> double-click handler (see the following screenshot). The first click
> was performed on the item label, the second - to the right of the
> label, the second - on the subitem.
>
> http://imageshack.us/photo/my-images/822/listctl.png
>
> As you can see hit-test flags on the second and third click contain
> the LVHT_ONITEMSTATEICON flag. Therefore then the user double-clicks
> anything but item label the above check triggers return and the diff
> is not called.
>
> I tested this program on the Windows XP and Server 2003 R2 x64 with
> the same result, but unfortunately I don't have Vista or 7 around.

Seems XP sets this flag for clicks on columns as well - which is a bug
IMHO since a click on e.g. column 2 clearly is nowhere near the state icon.

Worked around this in r22226.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2869384
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].