RE: Re: Commit Dialog: Double click to "Compare with base" does not work

A little research revealed the following check in the SVNStatusListCtrl.cpp, lines 3701-3704 (function CSVNStatusListCtrl::OnNMDblclk):

UINT hitFlags = 0;
HitTest(pNMLV->ptAction, &hitFlags);
if (hitFlags & LVHT_ONITEMSTATEICON)
    return;

I made a small test program that logs hit-test flags in the double-click handler (see the following screenshot). The first click was performed on the item label, the second - to the right of the label, the second - on the subitem.

http://imageshack.us/photo/my-images/822/listctl.png

As you can see hit-test flags on the second and third click contain the LVHT_ONITEMSTATEICON flag. Therefore then the user double-clicks anything but item label the above check triggers return and the diff is not called.

I tested this program on the Windows XP and Server 2003 R2 x64 with the same result, but unfortunately I don't have Vista or 7 around.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2868941

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-10-31 10:51:59 CET