[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ! Some Characters in Path Cause Troubles (eg in Externals)

From: Synetech <synetech_at_gmail.com>
Date: Mon, 13 Jul 2009 07:09:52 -0700 (PDT)

Stefan Küng wrote:
> The external path is never sent - that's uses locally only (only the
> local client has to know the name of the folder where the externals
> should be stored).
> And TSVN properly escapes all urls in all places, except in the the
> external properties because it would have to parse those properties for
> the urls to escape. And escaping the target path is not an option since
> I'm not aware of a documentation in the svn lib which chars need such
> escaping - so 'guessing' which ones that might be is never a good idea :)

Hmm, then I guess the problem is in the checkout/update functions.

If I issue a checkout using the SVN command-line (svn.exe), it can
properly pull the files from an external that has non-alphanumeric
characters in the URL. It is the same with AnkhSVN.

Just to make things even more confusing; VisualSVN (which uses
TortoiseSVN for its main functions) can also correctly pull files from
an external that contains non-alpha characters in the URL.

So far, only TortoiseSVN’s native (ie shell-extension) checkout/update
functions that give an error when an attempt is made to checkout some
code that has an external with non-alphanumeric characters in the URL.

> Synetech wrote:
> > Okay, I just tried manually escaping the characters in the external
> > and it works. It’s not pretty though since it requires the user to
> > manually escape them.
> >
> > VisualSVN, svn.exe, etc. all accept non-alpha characters for
> > importing, setting properties, and checkouts, without the user
> > manually escaping. Even TSVN accepts non-alpha characters in several
> > places. It seems that the externals are one of the only places that
> > are not automatically escaped by the program. (It kind of reminds me
> > of the old SQL-Injection vulnerability thing, where the program is not
> > escaping special characters on its own.)
> >
> > Fortunately it should be simple enough to fix: just escape the
> > external paths before sending them. :)
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-07-13 16:10:22 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.