Re: ! Some Characters in Path Cause Troubles (eg in Externals)

Synetech wrote:
> Okay, I just tried manually escaping the characters in the external
> and it works. It’s not pretty though since it requires the user to
> manually escape them.
>
> VisualSVN, svn.exe, etc. all accept non-alpha characters for
> importing, setting properties, and checkouts, without the user
> manually escaping. Even TSVN accepts non-alpha characters in several
> places. It seems that the externals are one of the only places that
> are not automatically escaped by the program. (It kind of reminds me
> of the old SQL-Injection vulnerability thing, where the program is not
> escaping special characters on its own.)
>
> Fortunately it should be simple enough to fix: just escape the
> external paths before sending them. :)

The external path is never sent - that's uses locally only (only the
local client has to know the name of the folder where the externals
should be stored).
And TSVN properly escapes all urls in all places, except in the the
external properties because it would have to parse those properties for
the urls to escape. And escaping the target path is not an option since
I'm not aware of a documentation in the svn lib which chars need such
escaping - so 'guessing' which ones that might be is never a good idea :)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2370914
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].