[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TSVN 1.5.5 - UI glitches

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 20 Mar 2009 21:08:05 +0100

webpost_at_tigris.org wrote:
> Hello!
>
> Unfortunately I can't currently upgrade to the latest version of
> TSVN, but seeing the new release coming I'd like you to check if the
> things I noticed are fixed.

Such a report two days before a release is way too late, sorry. Such
changes will have to wait at least for 1.6.1.

> Open the Checkout dialog from a folder context menu, then press the
> Tab button repeatedly to navigate through the controls. The
> "Checkout Depth" combobox comes after the Help button in the Tab
> Order. Expected: after the "Checkout directory"'s "..." button.

Ok, fixed.

> Open the "Switch To Branch / Tag" dialog. The first control to have
> focus is the "Switch:" field containing the folder the dialog was
> called for. I'd prefer the "To URL" combobox to be in the focus by
> default, because very often I just want to select a recent folder by
> pressing the down arrow on the keyboard, whereas I see no use in
> having the current folder's name selected.

Since it was requested before that the switch field should be selected,
I'll leave that as it is.

> In the "Merge" wizard on the "Merge revision range" page both "Show
> log" buttons have the same "&l" accelerator, therefore you can only
> access the top button by pressing Alt+L. Now do press the top button

There are not enough accelerator keys available :(

> and take a look at the "Select revision range" Log window. Select a
> revision using the keyboard (e.g. Shift+Down). Despite the fact that
> the "OK" button is displayed as "default" and has the "&O"
> accelerator underlined, neither Enter nor Alt+O work in the dialog.

That's changed in the upcoming release.

> Finally, two of the most annoying glitches of the Commit dialog.
> 1) Open the Commit dialog with at least three modified files (the
> number is not really important, it's just for my illustration).
> Highlight the second file e.g. by clicking on it. Now hit F5 to
> refresh the list. You can still see the second line highlighted,
> don't you? Press Down arrow on the keyboard to move the highlight
> down (or even the Spacebar to uncheck the file). Expected: third
> file highlighted (file unchecked). Reality: first file highlighted
> (nothing changed).

It's highlighted, but not focused anymore. The color is slightly different.

> 2) I often have a Commit dialog open while I work on the files to be
> committed, perhaps writing or correcting the log message as I work.
> One thing bit me a few times is that new files are not automatically
> added to the Commit file list when you switch to the dialog. What's
> worse, they have "checked" status by default, so you have to
> remember to refresh the list before committing, otherwise you may
> end up including unwanted files in the commit. I.e. in the dialog
> you see one file list, but actually a different list is committed,
> with all the previously unlisted versioned files "checked".
> That's a big UI problem, if you ask me. Granted, it can be too
> expensive for a huge WC to refresh the list when the dialog window
> gets activated, so you could make it an option for those not working
> with too big WCs. But in any case I think that when the user clicks
> "OK" there should at least be a warning that there are some files
> about to be committed not previously displayed in the dialog.

Adding new files automatically would be a bad idea. And if you hit F5 to
refresh, new files are *not* checked by default.

Also: if you keep the commit dialog open and you then modify files while
the dialog stays open, the commit dialog will notice that (it runs a
watcher thread in the background) and revert back to non-recursive
commits, i.e. your 'new' files will not be included in the commit.

Of course, that only works for local working copies - wcs on a network
share can not be reliably watched for changes and that can make the
watcher thread fail to detect such changes.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1366876
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2009-03-20 21:08:32 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.