[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Accessing %VERSION% parameter in update hook batch script

From: Simon Large <simon.tortoisesvn_at_googlemail.com>
Date: Sat, 8 Mar 2008 21:48:49 +0000

On 08/03/2008, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> Simon Large wrote:
> > On 07/03/2008, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> >> Simon Large wrote:
> >>
> >> >> Should we change our hook scripts to always pass *all* params in a
> >> >> defined way?
> >> >
> >> > That would make the behaviour more like svn hooks, and we could also
> >> > provide hook templates which would help with the documentation.
> >> >
> >> > Are there any disadvantages? What do others think?
> >>
> >>
> >> One disadvantage, yes: the %PATHS% replacement would have to be dropped.
> >> Because if that one is passed always, we could easily (too easily) cross
> >> the limit of the command line length.
> >> That means we'd have to only use %PATH% (the temp file containing the
> >> list of files), which however makes it harder to write hook scripts
> >> (they will have to read and parse that file first).
> >
> > I don't think that is a great loss. It should be no harder to parse a
> > file containing one filename per line than it is to parse a single
> > command line argument containing multiple filenames.
>
>
> Done in r12295.

If the hook script settings include other command line parameters, are they:
a) sent before the fixed params
b) sent after the fixed params
c) ignored

Not sure what they might be used for, just asking.

Also, should we include the hook templates in the installer or do we
just point users to our contrib folder?

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: users-help_at_tortoisesvn.tigris.org
Received on 2008-03-08 22:48:56 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.