Re: Line endings can cause commit dialog to stop adding non-versioned files without warning

John Williams wrote:
> TortoiseSVN 1.4.7, Build 11792 - 32 Bit , 2008/01/05 13:50:18
>
> Issue:
> When SVN config is setup for line endings for specific mime-types, there
> is an issue if a file containing mixed line endings is added/committed.
> This is not a problem if there is just one file added, it's a problem
> when adding multiple non-versioned files. Specifically, if adding many
> files, the commit appears to succeed, but only up to and including the
> offending file. There's no warning, but a keen eye will reveal that the
> number of files added is less than expected and there are still
> non-versioned files because they were not added. A workaround is to just
> commit again.
>
> Reproduce:
> 1) Tell SVN about line endings in the config file:
> *.css = svn:mime-type=text/css;svn:eol-style=native
>
> 2) Create 2 test files:
> style.css
> z.txt
>
> 3) Edit style.css so that it contains some text with CR/LF and LF line
> endings.
>
> 4) Commit, and in the commit dialog select both non-versioned files. The
> order the files are added is important because files following style.css
> are affected.
>
> What happened?
> style.css was added, but z.txt was not, there is no warning.
>
> What I think should have happened:
> All selected files should be added, because the offending file is added
> OK, why can't it continue with the good files? Or if this is illegal
> then a warning should be shown and/or nothing added.
>
> 5) A workaround, commit again to add the non-versioned files.

Thanks for the report.
Fixed in revision 11870: if the add of the files fails, an error is
shown and the commit is aborted (the commit dialog stays open).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: users-help_at_tortoisesvn.tigris.org