[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Line endings can cause commit dialog to stop adding non-versioned files without warning

From: Lasse Vågsæther Karlsen <lasse_at_vkarlsen.no>
Date: Mon, 14 Jan 2008 18:09:38 +0100

Unfortunately, svn stops with an error on the files that have incorrect line
endings, and then afterwards only commits the files added.

If you check the properties on the files you in the end have committed
you'll notice that the line-ending property has not been added for the files
that was incorrect.

On Jan 14, 2008 5:02 PM, John Williams <xrayz_at_bigfoot.com> wrote:

> TortoiseSVN 1.4.7, Build 11792 - 32 Bit , 2008/01/05 13:50:18
>
> Issue:
> When SVN config is setup for line endings for specific mime-types, there
> is an issue if a file containing mixed line endings is added/committed.
> This is not a problem if there is just one file added, it's a problem
> when adding multiple non-versioned files. Specifically, if adding many
> files, the commit appears to succeed, but only up to and including the
> offending file. There's no warning, but a keen eye will reveal that the
> number of files added is less than expected and there are still
> non-versioned files because they were not added. A workaround is to just
> commit again.
>
> Reproduce:
> 1) Tell SVN about line endings in the config file:
> *.css = svn:mime-type=text/css;svn:eol-style=native
>
> 2) Create 2 test files:
> style.css
> z.txt
>
> 3) Edit style.css so that it contains some text with CR/LF and LF line
> endings.
>
> 4) Commit, and in the commit dialog select both non-versioned files. The
> order the files are added is important because files following style.css
> are affected.
>
> What happened?
> style.css was added, but z.txt was not, there is no warning.
>
> What I think should have happened:
> All selected files should be added, because the offending file is added
> OK, why can't it continue with the good files? Or if this is illegal
> then a warning should be shown and/or nothing added.
>
> 5) A workaround, commit again to add the non-versioned files.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe_at_tortoisesvn.tigris.org
> For additional commands, e-mail: users-help_at_tortoisesvn.tigris.org
>
>

-- 
Lasse Vågsæther Karlsen
mailto:lasse_at_vkarlsen.no
http://presentationmode.blogspot.com/
PGP KeyID: 0xBCDEA2E3
Received on 2008-01-14 18:09:48 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.