Re: TSVNCache questions

Robert Roessler wrote:

> BUT, in the case I keep raising (path\ vs path\*), with an Include entry
> of path\, the VERY NEXT compare, which WILL BE EXECUTED (since the prior
> compare fails as you point out), results in 'equal'...!
>
> AND, THIS compare (the final if in your snippet of code above) is
> fundamentally incorrect... consider what it will do with an Include
> entry of path\ and checked paths of pathA, pathAA, pathAAA, etc.
>
> It will behave EXACTLY like path*, which it should NOT.

Yes, you're right. I guess I have to do something about that...

> BTW, this could likely be fixed by changing the LAST "I->size()-1" in
> your snippet to "I->size()"... although this fix MIGHT finally cause the
> infamous path\ to not be equivalent to path\*, depending on whether
> folder paths always have a trailing \ or not. ;)

IIRC, that comparison was implemented to make 'path\' behave the same as
  'path\* path', i.e. to make it more like what users expect.

>> Given the fact that a normal user doesn't understand such an ordering,
>> I think we should keep it that way.
>
> Obviously a judgment call, and it is not my app, but clearly the
> Apache-style semantic specification for specifying inclusion/exclusion
> is more powerful (and complete) - but you are likely correct in
> rejecting it because of the overkill factor. ;)

Don't forget that the cache now only monitors *working copies*. Unlike
before where it monitored the whole drives. Now, the monitoring is done
on working copy roots (more monitoring points, but that shouldn't be a
problem). Which reduces the need for such configuring of the
include/exclude paths a lot.

> Which brings me to my final (for now) point: the TSVNCache executable
> from rev 11400 DOES NOT WORK PROPERLY (on my XP SP2 system with NTFS).

See here:
http://nightlybuilds.tortoisesvn.net/latest/changelog.html#r11402

Please try a nightly build after that fix. And maybe even wait for the
next one (in case you're using it on Vista, that's strongly recommended).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org