[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Empty log message replaced with "made a copy"

From: Simon Large <simon.tortoisesvn_at_googlemail.com>
Date: 2007-08-23 11:44:05 CEST

On 23/08/07, Matuschka, Sebastian <Sebastian.Matuschka@gcd-solutions.de> wrote:
> i've made a pre-commit program for subversion that checks for empty log
> messages and realized that if i copy a directory by clicking on Branch /
> Tag in the context menu and enter no log message that the log message
> will be "made a copy". So my pre-commit thougt the user entered a
> message. At the moment i catch not only empty log messages but also
> "made a copy". I've looked in the code of Tortoise an found the line
> where "made a copy" is sent as log message when the log message is empty
> in SVN.cpp:
> if (logmsg.IsEmpty())
> m_pctx->log_msg_baton2 =
> logMessage(CUnicodeUtils::GetUTF8(CString(_T("made a copy"))));
> As far as i know this is the only exception, but i don't know it
> exactly, i'm not familiar with the tortoise code.
> So my questions are:
> Why is this there but not when other operations are made?
> Are there any similar cases which i have to catch as empty log message?
>
> I looked in the newest SVN.cpp in the Version-Control-System, but it's
> still there.

There's a conflict in requirements here. Particularly in repo browser,
these messages are useful as it is otherwise far too easy to just
click through the OK button and create a copy or new folder with no
log message at all. Been there, done that.

On the oher hand, having a default message defeats pre-commit hooks
and the tsvn:MinLogMinMessageMinLength (I know there's a Min in there
somewhere).

I don't know if it's possible to do this in repo browser too, but
maybe if there is a min log message length set we could suppress using
the default message?

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Thu Aug 23 11:41:31 2007

This is an archived mail posted to the TortoiseSVN Users mailing list.