Re: Overlays no longer showing up on "subst" drive

Tobias Schäfer wrote:

> I created a subst drive with "subst s: d:\development\svn\tortoisesvn"
> and it works just fine. However the visibility of the overlays now depends on
> "Fixed drives" and not "Network drives" as stated earlier.
> Today, I actually once had the behaviour you described, but cannot reproduce
> it. Very strange.

Just did the same here. I get 'fixed drive' for the subst'ed drive which
points to my TSVN working copy.
So the overlays are shown as they should.

> Looking at the source I might have an explanation.
> In src\TortoiseShell\ShellCache.h, Line 197:
>
> if (((drivetype == DRIVE_REMOTE)||(drivetype == DRIVE_NO_ROOT_DIR))
> &&(!IsRemote()))
> return FALSE;
>
> The subst-ed drive is not of the type DRIVE_REMOTE and it might be possible
> that windows reports DRIVE_NO_ROOT_DIR when the subst-ed drive is not
> initialised properly. In this case the overlays are influenced by the check
> mark "Network drives". This doesn't look correct.

DRIVE_NO_ROOT_DIR is only returned for UNC paths like
\\computer\sharename\workingcopy. So that shouldn't be a problem.

> Maybe this instead:
> if ((drivetype == DRIVE_REMOTE) &&(!IsRemote())
> return FALSE;
> if (drivetype == DRIVE_NO_ROOT_DIR)
> return FALSE;

In that case, you would not show overlays at all for any UNC path. I
don't think we should do that. With the existing code, UNC paths are at
least allowed to have overlays if the 'network drives' checkbox is
activated.

> Stefan, you changed that line in revision 1847. Could you please have a closer
> look. i doubt though that this solves the problem from Pierre at all. I guess
> Windows is not requesting the overlays for whatever reason.

Maybe a 'cleanup' of the substed drive would force the cache to crawl
the drive and show the overlays? Worth a try...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org