[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Overlays no longer showing up on "subst" drive

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2006-04-17 21:55:47 CEST

On Monday 17 April 2006 17:36, Pierre Arnaud wrote:
> > Have you checked that "Settings/Look and Feel/Icon Overlays/Network
> > drives" is selected?
> Yes. I tried setting it. It does not change the behaviour. In the real
> source folder, the overlays appear, but not on the same folder through
> a 'subst' drive letter.

I created a subst drive with "subst s: d:\development\svn\tortoisesvn"
and it works just fine. However the visibility of the overlays now depends on
"Fixed drives" and not "Network drives" as stated earlier.
Today, I actually once had the behaviour you described, but cannot reproduce
it. Very strange.

Looking at the source I might have an explanation.
In src\TortoiseShell\ShellCache.h, Line 197:

if (((drivetype == DRIVE_REMOTE)||(drivetype == DRIVE_NO_ROOT_DIR))
        return FALSE;

The subst-ed drive is not of the type DRIVE_REMOTE and it might be possible
that windows reports DRIVE_NO_ROOT_DIR when the subst-ed drive is not
initialised properly. In this case the overlays are influenced by the check
mark "Network drives". This doesn't look correct.

Maybe this instead:
if ((drivetype == DRIVE_REMOTE) &&(!IsRemote())
        return FALSE;
if (drivetype == DRIVE_NO_ROOT_DIR)
        return FALSE;

Stefan, you changed that line in revision 1847. Could you please have a closer
look. i doubt though that this solves the problem from Pierre at all. I guess
Windows is not requesting the overlays for whatever reason.


To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Mon Apr 17 21:56:22 2006

This is an archived mail posted to the TortoiseSVN Users mailing list.