Re: tortoiseplink error

seph wrote:
>>Check the changelog: 1.2.3 was replaced by 1.2.4 because TortoisePlink
>>didn't work.
>
>
> well, 1.2.4 didn't work for me, while 1.2.2 did.

If you check the diff below, there's nothing in there between 1.2.2 and
1.2.4 that would make TortoisePlink not work anymore. I've only added
some variable initializations (due to compiler warnings) and also
enhanced the error messages a little bit.

Stefan

svn diff
http://tortoisesvn.tigris.org/svn/tortoisesvn/tags/version_1.2.2/src/TortoisePlink
http://tortoisesvn.tigris.org/svn/tortoisesvn/tags/version_1.2.4/src/TortoisePlink

gives us:

Index: PLINK.C
===================================================================
--- PLINK.C (.../version_1.2.2/src/TortoisePlink) (Revision 4711)
+++ PLINK.C (.../version_1.2.4/src/TortoisePlink) (Revision 4711)
@@ -305,14 +305,14 @@
      HANDLE handles[4];
      DWORD in_threadid, out_threadid, err_threadid;
      struct input_data idata;
- int reading;
- int sending;
+ int reading = 0;
+ int sending = 0;
      int portnumber = -1;
- SOCKET *sklist;
+ SOCKET *sklist = NULL;
      int skcount, sksize;
- int connopen;
- int exitcode;
- int errors;
+ int connopen = 0;
+ int exitcode = 0;
+ int errors = 0;
      int use_subsystem = 0;

      ssh_get_line = console_get_line;
@@ -770,7 +770,7 @@
          } else if (n == 2) {
              odata.busy = 0;
              if (!odata.writeret) {
- mboxprintf("Unable to write to standard output\n");
+ mboxprintf("Unable to write to standard output (stdout)\n");
                  cleanup_exit(0);
              }
              bufchain_consume(&stdout_data, odata.lenwritten);
@@ -783,7 +783,7 @@
          } else if (n == 3) {
              edata.busy = 0;
              if (!edata.writeret) {
- mboxprintf("Unable to write to standard output\n");
+ mboxprintf("Unable to write to standard output (stderr)\n");
                  cleanup_exit(0);
              }
              bufchain_consume(&stderr_data, edata.lenwritten);
Index: TortoisePlink.vcproj
===================================================================
--- TortoisePlink.vcproj (.../version_1.2.2/src/TortoisePlink) (Revision
4711)
+++ TortoisePlink.vcproj (.../version_1.2.4/src/TortoisePlink) (Revision
4711)
@@ -552,5 +552,8 @@
                  </Filter>
          </Files>
          <Globals>
+ <Global
+ Name="DevPartner_IsInstrumented"
+ Value="0"/>
          </Globals>
  </VisualStudioProject>

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
--