CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit

Hi,
testing a check_commit_hook - script I found an unexpected behaviar of the commit dialog.
My script returns an error and the dialog shows the errormessage. If I press abort, things go in the expected way. But if I press Esc on keyboard, commit is proceeding. I would say, this is an error.
In source I found that abort is done on a return value of 1 only (taskdlg.DoModal). Wouldn't it be better, only to proceed committing if the return value is 2?

Regards,
Willi

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3185034

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2016-09-07 16:49:01 CEST