[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch for ticket 694

From: Daniel Sahlberg <daniel.l.sahlberg_at_gmail.com>
Date: Sun, 24 Jan 2016 14:30:12 +0100

Hi Stefan,

You got my point exactly: I would want to wait for the processes to end, to
avoid starting 24 separate processes at the same time. Of course, maybe not
much better to start 24 processes after each other.

A nicer solution would be to be able to do the update without triggering
the update dialog; I didn't look at the code that does the actual update
but maybe that should be possible to call within the same process.

Something better, for a power user with a lot of projects, might be to also
have an "Update all" in the project tree - that should update any projects
in that particular folder (including subfolders).

If you want I can continue to look at this, if you just give me a few
pointers how you would like to arrange the code.

Kind regards
Daniel

2016-01-24 13:39 GMT+01:00 Stefan Küng <tortoisesvn_at_gmail.com>:

> On 23.01.2016 21:25, Daniel Sahlberg wrote:
> > Hi,
> >
> > I'm looking at the open tickets and have made a patch, which if I
> > understand the request correctly, should solve ticket 694
> > (http://sourceforge.net/p/tortoisesvn/tickets/694/).
> >
> > One note: The patch use RunTortoiseProc which doesn't wait for the
> > update to complete before returning. It would be easy enough to add
> > another parameter (with a default value, to avoid changing elsewhere)
> > for it to wait for each update process to complete. Your opinion?
>
> Why would you want to wait for the process to end?
>
>
> > Two of the changed files, TortoiseProcENG.rc and resource.h, have the
> > mime-type application/octet-stream and I couldn't come up with a better
> > idea then to create a diff with the --force parameter. Please advice if
> > I should send the changes in another way.
>
> usually just zip those files and attach it.
>
>
> About your patch:
> You're starting a separate tortoiseproc process for every single
> monitored working copy. So with my setup, that would result in 24
> processes. Yikes!
>
> I'll have to code something else to do the updates, because this doesn't
> scale at all.
>
> Stefan
>
> --
> ___
> oo // \\ "De Chelonian Mobile"
> (_,\/ \_/ \ TortoiseSVN
> \ \_/_\_/> The coolest interface to (Sub)version control
> /_/ \_\ http://tortoisesvn.net
>
> ------------------------------------------------------
>
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3156818
>
> To unsubscribe from this discussion, e-mail: [
> dev-unsubscribe_at_tortoisesvn.tigris.org].
>

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3156832

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2016-01-24 14:30:53 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.