Re: Patch for ticket 694

On 23.01.2016 21:25, Daniel Sahlberg wrote:
> Hi,
>
> I'm looking at the open tickets and have made a patch, which if I
> understand the request correctly, should solve ticket 694
> (http://sourceforge.net/p/tortoisesvn/tickets/694/).
>
> One note: The patch use RunTortoiseProc which doesn't wait for the
> update to complete before returning. It would be easy enough to add
> another parameter (with a default value, to avoid changing elsewhere)
> for it to wait for each update process to complete. Your opinion?

Why would you want to wait for the process to end?

> Two of the changed files, TortoiseProcENG.rc and resource.h, have the
> mime-type application/octet-stream and I couldn't come up with a better
> idea then to create a diff with the --force parameter. Please advice if
> I should send the changes in another way.

usually just zip those files and attach it.

About your patch:
You're starting a separate tortoiseproc process for every single
monitored working copy. So with my setup, that would result in 24
processes. Yikes!

I'll have to code something else to do the updates, because this doesn't
scale at all.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3156818
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].