On 24.02.2015 15:18, otik wrote:
> Hi stefan.
>
> About month ago I fixed bug which bit annoyed me long time, for long
> time I could not figure out when it happens.
>
> When you open TMerge (e.g. diff some changed text file) with more lines
> then fit in view and then click on navigation bar. You see left and
> right views are out of sync. (by one line in my case)
> This stop to happen when you resize window.
>
> This is becouse when first time view is checking LineNumber in
> GetLineNumber scroll is not ready yet. So it rememebers LineNumber for
> height 0. Then ScrollBar is created, but LineNumber is not recalculated.
>
> My approach was to don't remember LineNumber until ScrollBar is ready,
> better would be reset it when scrollbar is created.
> My guess would be some message to View is delivered about change client
> area at that time.
Ah, that was the issue you were trying to fix. From your commit message
I couldn't find a way to reproduce the problem since I couldn't figure
out what you meant exactly.
The problem with your approach was that you not just didn't use the
cache but you also returned always zero if the scrollbar wasn't visible.
That lead to problems if the file content fully fits into the view: then
the scrollbar is not visible but the view still has more than zero
screen lines. And that lead to all kinds of problems (e.g., scrolling
automatically by simply holding down the mouse button on any line).
I've committed a fix soon: I have something that seems to work ready but
I need to do some more testing.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest interface to (Sub)version control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3100935
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2015-02-24 19:55:18 CET