Re: Comment on revision r25052 in tortoisesvn

On 28.12.2013 09:39, Oto BREZINA wrote:
> On 2013-12-28 09:01, Stefan Küng wrote:
>> On 28.12.2013 08:54, Oto BREZINA wrote:
>>> On 2013-12-26 18:26, tortoisesvn_at_googlecode.com wrote:
>>>> Comment by XhmikosR:
>>>>
>>>>
>>>> In line `return x % m_nTabSize ? m_nTabSize - (x % m_nTabSize) :
>>>> m_nTabSize;`, can you add parentheses to clarify the expression?
>>> Does it make sense at all?
>>> m_nTabSize - (x % m_nTabSize)
>>> seems to be enought.
>>>
>> I thought so too, but apparently it's not clear enough for everyone.
>> So it doesn't hurt to add parenthesis to ensure everyone gets it.
>
> I meant replace
> x % m_nTabSize ? m_nTabSize - (x % m_nTabSize) : m_nTabSize
> by
> m_nTabSize - (x % m_nTabSize)
>

Yes, that's much better.
Done in r25087.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3070902
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].