Re: Comment on revision r25052 in tortoisesvn

On 2013-12-28 09:01, Stefan Küng wrote:
> On 28.12.2013 08:54, Oto BREZINA wrote:
>> On 2013-12-26 18:26, tortoisesvn_at_googlecode.com wrote:
>>> Comment by XhmikosR:
>>>
>>>
>>> In line `return x % m_nTabSize ? m_nTabSize - (x % m_nTabSize) :
>>> m_nTabSize;`, can you add parentheses to clarify the expression?
>> Does it make sense at all?
>> m_nTabSize - (x % m_nTabSize)
>> seems to be enought.
>>
> I thought so too, but apparently it's not clear enough for everyone.
> So it doesn't hurt to add parenthesis to ensure everyone gets it.

I meant replace
x % m_nTabSize ? m_nTabSize - (x % m_nTabSize) : m_nTabSize
by
m_nTabSize - (x % m_nTabSize)

-- 
Oto BREZINA, Printflow s.r.o., J. Hagaru 9, BRATISLAVA,
www.printflow.eu, brezina_at_printflow.eu.
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3070879
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].