[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Sparse checkout: items selection dialog

From: Sergey Azarkevich <azarkevich_at_gmail.com>
Date: Fri, 6 Sep 2013 00:30:58 +0300


> > Is it principal position - empty default selection? Or it is only way
> > for avoid mentioned 'side effect'?
> > From my point of view 'Fully recursive' default selection is more
> > logical and this side effect is desired.
> The default should be empty - after all you want to exclude stuff,
> that's why you get to that dialog.
Well, of course I want exclude stuff, so I want uncheck it....

But OK. I inserted your variant in patch and fix all remarks.

Additionally new patch has next changes:

* in 'Update to revision' mode default state for just inserted item, absent
in m_wcDepths map - unchecked.
* nodes without children (empty directories and files) also has checkbox
with "two-state" behavior.
* in code for support Windows XP version was added workaround. Not sure if
it is good way.


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2013-09-06 14:03:09 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.