Re: [PATCH] Sparse checkout: items selection dialog

>

> > 1. When tree item inserted into tree, it inherit parent check state
> >
> > I think it is logical - expand checked item and see all children
> > checked. Expand unchecked item and see all items unchecked
> >
> > As side effect all items initially checked (inherit root check state).
>
> Use this instead:
> // inherit parents check state
> if (m_RepoTree.GetRootItem() == hParent)
> m_RepoTree.SetCheck(hNewItem, false);
> else
> m_RepoTree.SetCheck(hNewItem, m_RepoTree.GetCheck(hParent));
>
>
Is it principal position - empty default selection? Or it is only way for
avoid mentioned 'side effect'?
From my point of view 'Fully recursive' default selection is more logical
and this side effect is desired.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3063934

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-09-05 01:34:49 CEST