Re: BugTraq commit button grayed out during initialization

Stefan wrote:

>you can see that the method GetCommitMessage() and/or
>GetCommitMessage2() has a parameter 'pathList' which is the list of
>paths that are shown in the commit dialog.

>That's why the button is disabled until the file list is shown in the
>commit dialog: that list is required to pass to the issue tracker plugin
>- as long as that list isn't know, we can't call the plugin.

I understand. 

In our particular use case, we really don't care about duplicating the path list in our story tracker - the path list will be committed to  SVN and can later be retrieved on demand from TSVN you know the revision number.  Hypothetically - if the path list was not ready yet, one could call GetCommitMessage() or GetCommitMessage2() with an empty pathList (or a dummy entry saying - not ready yet). The implementation of the Jira plugin only writes that list of committed files to the version tracker only in OnCommitFinished(), and only if the user sets this behavior through an svn property. Whether that behavior is allowed could be controlled by an option.

I don't really feel strongly about this, because normally filling in the list of files in the commit dialog is really quite fast.  Making this change is probably not worth the trouble.  I will ask for further feedback from people who use this, and if lots of people complain we can revisit this.

F.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3057824

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-06-12 16:26:54 CEST