On 2013-04-22 21:27, Stefan Küng wrote:
> On 22.04.2013 21:12, Oto BREZINA wrote:
>> On 2013-04-21 21:06, tortoisesvn_at_googlecode.com wrote:
>>> Comment #2 on issue 468 by tortoisesvn: Allow edit in left view
>>> http://code.google.com/p/tortoisesvn/issues/detail?id=468
>>>
>>> one problem that has to be fixed before the 1.8 release:
>>>
>>> when editing a diff using the commands like "use mine" and others, the user
>>> intends to only edit the right view. Of course by using those commands, the
>>> left view gets 'edited' as well. And that triggers the 'do you want to
>> Why left view should be mark as edited if it is only a source? Saving
>> that view will produce exactly the same file. Isn't it?
>> You sad "Of course" I don't see reason for that. In some command I
>> eliminated that mark as modified not done in all yet.
> I was confused: the left view isn't marked modified, but there was still
> a dialog asking to save it.
>
>>> save' dialog for the left view even though the user hasn't actually edited
>>> the left view. Very confusing and annoying.
>> This one was fixed by 24128 ?
> yes.
>
> Stefan
>
I'll keep this issue open for about week if no new issues appear it can
be closed.
Right now only issue I see is when use block is used it changes line
states in not very natural way for me.
e.g when copying block from left to right(this first, or this last), all
lines on right are set as new. The other way is even more confusig,
those lines get removed.
My suggestion:
When copying - both sides are set to "not diff". Actually new states
should be as close as possible (reasonably close) to state after reload.
Do you agree?
Oto
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3053976
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-04-22 21:52:16 CEST