[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fixes 16-04-2012

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Mon, 16 Apr 2012 20:19:41 +0200

On 16.04.2012 12:55, abel_at_abel.hu wrote:
> Hello,
>
> here are some fixes.
>
> RepositoryBrowser
> - resource leak fixed
> - possible crash fixed
>
> BaseView
> - usage of a temporary CString object fixed
> - possible crash fixed (checking of m_pViewData implies it can be NULL.
> SetViewData dereferences it.)
>
> Tooltip
> - unnecessary creation of a temporary CString object fixed
> - minor efficiency improvement
>
> LinkControl
> - intentional fallthrough should be marked
>
> HistoryCombo
> - usage of a temporary CString object fixed

HistoryCombo: you're trying to use m_tooltip which doesn't exist.
Why are you trying to use a member variable instead of the CString we
use on the stack? I don't see a reason for this?

Committed your changes in r22794 except the one for the HistoryCombo.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2948720
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-04-16 20:19:48 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.