[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fixes

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 13 Apr 2012 22:56:32 +0200

On 13.04.2012 21:38, abel_at_abel.hu wrote:
> Hi, Stefan!
>>> BaseView.patch
>> A few issues with this patch:
>> * uses tabs instead of spaces (easily fixed)
> Sorry, I'll replace them in the future.
>> * you're calling the expensive GetLineChars() method unconditionally (...)
> Sure, sorry, one minute after I sent the patch to the mailing list, I
> noticed my mistake and sent another letter, in which I described
> what's missing. Should I resend the whole patch file next time?

Not necessary. As you can see from my commits, I fixed it.
If I need you to resend the patch, I would mention that in my reply to
your patch.

>>> - ReadFile does not null-terminate the string it reads. Later pFileBuf
>>> is used as if it would be null-terminated.
>> While it's true that ReadFile does not null-terminate the buffer it
>> reads (doesn't need to be a string), it's not necessary here
> Yes, you're right.
>> also: your patches are invalid. Not sure if it's the mailer that messes
>> them up, but the first lines all have an empty line in between them. SVN
>> does not recognize those patches.
> I really don't understand what causes this. The patch files on my
> harddrive are correct. Looking at the attachments, I see exactly what
> you described. :S I'll put them in a zip file next time.

So I guess it gets messed up in the email chain somewhere.
Zipping them would definitely help.

> Sorry for the problems!

No problem at all. Thanks for the patches!


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-04-13 22:56:42 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.