Re: fixes

Hi, Stefan!

>> BaseView.patch
> A few issues with this patch:
> * uses tabs instead of spaces (easily fixed)
Sorry, I'll replace them in the future.

> * you're calling the expensive GetLineChars() method unconditionally (...)
Sure, sorry, one minute after I sent the patch to the mailing list, I
noticed my mistake and sent another letter, in which I described
what's missing. Should I resend the whole patch file next time?

>> - ReadFile does not null-terminate the string it reads. Later pFileBuf
>> is used as if it would be null-terminated.
>
> While it's true that ReadFile does not null-terminate the buffer it
> reads (doesn't need to be a string), it's not necessary here
Yes, you're right.

> also: your patches are invalid. Not sure if it's the mailer that messes
> them up, but the first lines all have an empty line in between them. SVN
> does not recognize those patches.
I really don't understand what causes this. The patch files on my
harddrive are correct. Looking at the attachments, I see exactly what
you described. :S I'll put them in a zip file next time.

Sorry for the problems!

Have a nice weekend,
Abel

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2948128

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-04-13 21:44:14 CEST