Re: new link-style buttons in commit dialog register on non-captured mouseup

On 09.03.2012 02:48, z wrote:
> testing in tsvn 1.7.6 build 22632 32bit on windows 2003.
>
> Start making a commit. use the recent messages button. Position the
> recent messages dialog so that an entry is directly over one of the
> link-style buttons (one of all, none, non-versioned, versioned, etc.)
> I recommend positioning it over non-versioned to experience the full
> madness. Now, doubleclick a recent message. Your mouse button will
> still be held down while this dialog is dismissed. Now release the
> mouse button. Since your mouse is over "non-versioned", at the moment
> of release, this button will be activated. All your non-versioned
> files will get checked.

I've opened issue #236 for this:
http://code.google.com/p/tortoisesvn/issues/detail?id=236

> This information is not just about the bug, but why it is severe:
> This is especially problematic if you have 100000s of non-versioned
> files, since you will not know that theyre being selected, and youll
> go to click OK to commit, and things will mysterious run slow and
> then suddenly all your junk will be added (since theyre all put into
> the add status when you click OK.. which I do not necessarily argue
> with) and your commit will now be a mess.

Now, while your report is ok, this definitely isn't.
Here's why:
The whole point of showing unversioned items in the commit dialog is to
immediately see what needs to be added to version control so you don't
forget to commit new files.
However, what you're describing here is that you have tons of
unversioned files which should never be versioned at all. This
completely defeats the purpose of showing unversioned files. You have to
*ignore* those files you never want versioned. That's what the
svn:ignore property is for - right-click on those files and choose one
of the entries in the 'ignore' submenu, directly from the commit dialog.

Or uncheck the option "show unversioned files" so they don't show up at all.

But what you're doing really is the wrong thing to do. You mentioned
that this issue is 'severe' - it's not. What's severe (or maybe better:
what makes this severe) is that you're 'doing it wrong'. If you would
use the svn:ignore property (or the global ignore patterns in the
settings dialog) this wouldn't be severe at all.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2933783
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].