Re: Clarify where hook errors occur

> When a server-side hook error occurs the commit dialog
> reports it as a hook error, but doesn't make it clear
> that the error has happened on the server side
> (especially since we also have client-side hooks).
> Maybe that error message could be extended something like this:
>
> post-commit hook failed (exit code 1) with output:
> Blah blah
> This error was generated by the Subversion server, not by TortoiseSVN.
> Please contact your server administrator for help with resolving this issue.

A very good idea! Perhaps we could make it even more clear by explaining that the message comes from a customization/specialization on the server, and not from the core Subversion code. This way we might steer some traffic away from the Subversion mailing lists and towards whoever installed the hook on the server.

I'm not totally positive on how such a message should read, but perhaps something like:

"
post-commit hook failed (exit code 1) with output:
Blah blah
This error was generated by a custom script on the Subversion server, not by TortoiseSVN.
Please contact your server administrator for help with resolving this issue.
"

Maybe we should change the order of the output as well, to keep the actual message generated by the hook on top. I sometimes get the feeling that users get freaked out by that initial line and stops reading. Suggestion:

"
Blah blah

This error was generated by a custom post-commit hook on the Subversion server that returned exit code 1.
Please contact your server administrator for help with resolving this issue.
"

Hans-Emil

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2890836

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-12-06 08:57:07 CET