If post-revprop-change hook has exit code 1, message in log message viewer is not updated

Here is a minor issue I came across today. It was reproduced with r21527,
with the command line tools installed.

 1. Run the attached
http://old.nabble.com/file/p31776157/PostRevPropChangeHookWithExitCode1.bat
PostRevPropChangeHookWithExitCode1.bat .
 2. Right click on `TestPostRevPropChangeHookWithExitCode1-wc`, TortoiseSVN
-> Show Log.
 3. `Edit log message` for revision 1 and change the log message. You should
see an error dialog because the post-revprop-change hook exited with error
code 1, but after closing the error dialog the log message as viewed in the
Log message viewer won't have changed. Refreshing with F5 doesn't change it
either. Go to `Edit log message` again and you'll see your edited log
message, as shown below. If we close and reopen the Log message viewer, we
see the edited log message. Perhaps this change is similar to r21525 in that
post-revprop-change errors shouldn't be treated as 'real' errors.

http://old.nabble.com/file/p31776157/TsvnErrorDialog.png

http://old.nabble.com/file/p31776157/TsvnLogDialog.png

Another unrelated issue is: when I download the svn and svnadmin binaries to
a directory, open a command prompt in that directory and type svn help, I
get the following error:

http://old.nabble.com/file/p31776157/EntryPointNotFound.png

svnadmin help returns normally. I did choose to install the command line
tools this time when I installed svn, and I had not done that in the past. I
suppose this is not really an issue for me since I can just use the command
line tools installed with TSVN, but I thought I'd mention the issue in case
it points to a problem that needs to be fixed.

-- 
View this message in context: http://old.nabble.com/If-post-revprop-change-hook-has-exit-code-1%2C-message-in-log-message-viewer-is-not-updated-tp31776157p31776157.html
Sent from the tortoisesvn - dev mailing list archive at Nabble.com.
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2758108
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].