[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TortoiseMerge /Create-Apply patch issues

From: Oto BREZINA <otik_at_printflow.eu>
Date: Fri, 20 May 2011 17:39:03 +0200

> Ok, just a hint to make it easier for you to find the problem and fix it:
>
> This is a problem with the coordinates:
> the selection is now handled with view coordinates, but the drawing
> still happens with screen coordinates.
>
> At least that's what I think from a quick glance over the code...
It is even more complicated. There are two screen coordiantes one 'char
based' (tab is one point) and one with tab expanded (tab is tabwidth
points).
I'm not sure if 'char based' was not introduced (by missunderdanding) by
me or not, but it seems to be good to remove one of then, just not sure
which one. Side note: tab handling as is (expand to char) does not
support KANJI properly (would not align - what is tabs purpose) so I
guess we will need some rewrite tab handling and/or
ScreenPosition<->ViewPosition calculation.

For a moment I want easy solution
to clean up bugs pollution :)

While using TabbedTextOut or similar function seems to be good solution
for most tab handling. However it would make drawing white spaces (tabs
namely) harder. I does not work at all with KANJI right now.

I still don't get thru inline diff colorer to find best solution.
> Stefan

-- 
Oto BREZINA, Printflow s.r.o., EU
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2742351
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-05-20 17:39:16 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.