[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [T-Merge Patch] Convert Text Selection to view coordinates

From: Oto BREZINA <otik_at_printflow.eu>
Date: Thu, 05 May 2011 22:08:42 +0200

On 2011-05-05 22:00, Stefan Küng wrote:
> On 05.05.2011 21:05, Oto BREZINA wrote:
>> * Convert Text Selection to view coordinates
>> * keep text selection over wrap line, window resize
>> * fix editing in wrap mode - for speed cost
>> * fix mark word while wrap on
> Too much of a performance problem with this one:
> You rebuild the screen2view vector on every entered char. While that
> would be acceptable (very bad, but acceptable for those who don't type a
> lot) if that method were only used when typing, it's also used when
> pasting text from the clipboard.
> Try pasting a few lines of text and you'll see what I mean.
You are right.
  * First it affect only when wrap mode on
  * Thing is I'm quite unsure how it bahave with no debug build.
  * I'm rewriting Text paste, but want to keep separate commits so you
can keep track and also easier revert (not sure if even posible)
> Also if I see FIXME statements I automatically go into high alert mode.
> At least add a comment what needs fixing and maybe how one would have to
> do so.
>
> btw: you can use "// TODO: blahblah" for this since we use that
> throughout the code - much easier to search for if you keep it
> consistent: just search for "TODO:" or "// TODO:"...
>
In both compiler i use (Gcc-avr and borland) is #warning - that's fine
if you want to make hard to ignore short and even long term note
> Stefan

-- 
Oto BREZINA, Printflow s.r.o., EU
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2731352
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-05-05 22:09:03 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.