[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [T-Merge Patch] Convert Text Selection to view coordinates

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 05 May 2011 22:00:43 +0200

On 05.05.2011 21:05, Oto BREZINA wrote:
> * Convert Text Selection to view coordinates
> * keep text selection over wrap line, window resize
> * fix editing in wrap mode - for speed cost
> * fix mark word while wrap on

Too much of a performance problem with this one:
You rebuild the screen2view vector on every entered char. While that
would be acceptable (very bad, but acceptable for those who don't type a
lot) if that method were only used when typing, it's also used when
pasting text from the clipboard.
Try pasting a few lines of text and you'll see what I mean.

Also if I see FIXME statements I automatically go into high alert mode.
At least add a comment what needs fixing and maybe how one would have to
do so.

btw: you can use "// TODO: blahblah" for this since we use that
throughout the code - much easier to search for if you keep it
consistent: just search for "TODO:" or "// TODO:"...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2731347
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-05-05 22:00:48 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.