[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Maybe patch - group all actions on one view in BaseView

From: Dmitry <wipedout_at_yandex.ru>
Date: Thu, 28 Apr 2011 12:53:58 +0400


27.04.11, 10:26, "Oto BREZINA" <otik_at_printflow.eu>:
> > Attaches is a maybe patch for code in BaseView. Currently operation goes like this "if view A is good, do action 1 on view A, then the same for views B and C, then if view A is good do action2 on view A, then the same for B and C". Is it possible to go like this: "is view A is good, do both 1 and 2, then proceed to B and also do 1 and 2, then same for C"? That would make further duplicaion reduction possible.
> Thanks, however:
> It would not work as build action2 needs 1 to be done for all views
> already. Anyway I hope that this is intermediate state only.

Okay, then attached is an untested patch that reduces duplication without altering control flow.

Best wishes.


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2011-04-28 10:54:02 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.