[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [T-Merge] wrap long lines issues a comments

From: Oto BREZINA <otik_at_printflow.eu>
Date: Sat, 23 Apr 2011 10:05:52 +0200

On 2011-04-23 09:47, Stefan Küng wrote:
> On 23.04.2011 09:40, Oto BREZINA wrote:
>>
>> On 2011-04-23 09:23, Stefan Küng wrote:
>>> On 23.04.2011 09:21, Oto BREZINA wrote:
>>>> On 2011-04-19 22:39, Stefan Küng wrote:
>>>> What is reason to have m_Screen2Vector copy for every view ? May they
>>>> differ?
>>>> I would say they are same so we build and store same 2-3 times.
>>>>
>>> They're not the same. Just compare two files, one with only one line,
>>> the other with 100 lines.
>> I will, but I gues, that smaller one would have 99 empty lines.
> Exactly. And the values in the vector are then definitely different.
Still don't get it. I did test with two files first have just line "1"
other have 10 line "0"-"9". Compare them.
As I understand:
There will be m_pViewData for both views with same size (different data
of course).

Here is code for building vector (sligthly modified).
void CBaseView::BuildScreen2ViewVector()
{
     m_Screen2View.clear();
     if (m_pViewData)
     {
         m_Screen2View.reserve(m_pViewData->GetCount()); // we expect
size same to number on views - this is true when wrapping and colapsing
are off
         for (int i = 0; i < m_pViewData->GetCount(); ++i)
         {
             //if (m_pMainFrame->m_bCollapsed)
                  // not happen - even would happen I expect same view
line would be collapsed for all views

             if (i < m_pViewData->GetCount())
             {
                 // if (m_pMainFrame->m_bWrapLines)
                  // not happen - even would have effect for all views
same number of sublines is added
                 m_Screen2View.push_back(i);
             }
         }
     }

What I read here is: one screen2view record for every viewline - same
for all three views.

> Stefan

-- 
Oto BREZINA, Printflow s.r.o., EU
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2722975
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-04-23 10:06:02 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.