[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - too long function, duplicate code, unnecessary actions.

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sat, 05 Mar 2011 20:40:04 +0100

On 05.03.2011 11:06, Dmitry wrote:
> Hey.
> Attached is an untested patch that addresses the following minor problems is RemoteCacheLink:
> - a function is too long
> - no sense to first have "ifndef", then "else" - it should be "ifdef", then "else"
> - if the process is 32-bit and not Wow64 and the first attemp to start TSVNCache.exe would fail the second attempt would have been made for the very same path
> - if the process is 32-bit Wow64 and there's a path from which a 64-bit TSVNCache would start successfully the path to 32-bit version would be computed and never used
> - code for computing the path to TSVNCache.exe is duplicated

Committed in r20970.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-03-05 20:40:19 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.