Re: Patch - no parameters validation, overly complex code

On 21.02.2011 07:55, Dmitry wrote:
> Hey.
>
> Attached is an untested patch that addresses the following issues:
> - pointers that are later dereferenced are not checked for being valid
> - "out" parameters are not set on control paths that return S_FALSE or S_OK
> - "class" with all public members is used instead of "struct"
> - overly complex code

Committed in r20905.

> Also there's a "switch(m_State)" that has no "default:" branch - what should happen there semantically? Should execution continue or should the code signal an error?

There are several such statements. But none of them really require a
default branch since the variable the non-default branches modify has
already been set to a default value.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2706328
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].