[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Patch - no parameters validation, overly complex code

From: Dmitry <wipedout_at_yandex.ru>
Date: Mon, 21 Feb 2011 09:55:16 +0300


Attached is an untested patch that addresses the following issues:
- pointers that are later dereferenced are not checked for being valid
- "out" parameters are not set on control paths that return S_FALSE or S_OK
- "class" with all public members is used instead of "struct"
- overly complex code

Also there's a "switch(m_State)" that has no "default:" branch - what should happen there semantically? Should execution continue or should the code signal an error?

Best wishes.


To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2011-02-21 07:55:32 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.