Re: [tortoisesvn] r20851 committed - short string messages should be limited to approx. 2 lines of text on ...

On 13.02.2011 14:56, Stefan Fuhrmann wrote:
> Stefan Küng <tortoisesvn_at_gmail.com
> <mailto:tortoisesvn_at_gmail.com?Subject=Re:%20[tortoisesvn]%20r20851%20committed%20-%20short%20string%20messages%20should%20be%20limited%20to%20approx.%202%20lines%20of%20text%20on%20...>>
> wrote:
>> On 12.02.2011 05:51, tortoisesvn_at_googlecode.com wrote:
>>
>> /> Revision: 20851 /
>> /> Author: stefan.fuhrmann.1974 /
>> /> Date: Fri Feb 11 20:46:51 2011 /
>> /> Log: short string messages should be limited to approx. 2 lines of
>> text on /
>> /> the screen /
>> /> (look for commit messages generated by svnmerge for an example) /
>> /> http://code.google.com/p/tortoisesvn/source/detail?r=20851 /
>> /> /
>> /> Modified: /
>> /> /trunk/src/TortoiseProc/ProjectProperties.cpp /
>> /> /
>> /> ======================================= /
>> /> --- /trunk/src/TortoiseProc/ProjectProperties.cpp Sat Feb 5
>> 16:35:57 2011 /
>> /> +++ /trunk/src/TortoiseProc/ProjectProperties.cpp Fri Feb 11
>> 20:46:51 2011 /
>> /> @@ -810,14 +810,16 @@ /
>> /> } /
>> /> sRet.Trim(); /
>> /> /
>> /> - if (sRet.IsEmpty()) /
>> /> - return sMessage; /
>> /> - /
>> /> return sRet; /
>>
>> Not sure why you removed that, but it's required. I added it back in
>> r20854.
>>
> Well, according to the docstring, these lines should be removed.
> If there is no match, an empty string must be returned.
>
> This function will only be called from MakeShortMessage() which
> will not fall back to its shortening logic unless GetLogSummary()
> returns an empty string.

Funny thing. I explicitly added that code in r20688. The reason was that
the log dialog failed to show log messages that didn't match the
property regex.
But now I know why: there just weren't any log messages to show in my
test repo :(

removed that again in r20860.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2703695
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].