[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [tortoisesvn] r20851 committed - short string messages should be limited to approx. 2 lines of text on ...

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Sun, 13 Feb 2011 14:56:54 +0100

Stefan Küng <tortoisesvn_at_gmail.com
<mailto:tortoisesvn_at_gmail.com?Subject=Re:%20[tortoisesvn]%20r20851%20committed%20-%20short%20string%20messages%20should%20be%20limited%20to%20approx.%202%20lines%20of%20text%20on%20...>>
wrote:
> On 12.02.2011 05:51, tortoisesvn_at_googlecode.com wrote:
>
> /> Revision: 20851 /
> /> Author: stefan.fuhrmann.1974 /
> /> Date: Fri Feb 11 20:46:51 2011 /
> /> Log: short string messages should be limited to approx. 2 lines of
> text on /
> /> the screen /
> /> (look for commit messages generated by svnmerge for an example) /
> /> http://code.google.com/p/tortoisesvn/source/detail?r=20851 /
> /> /
> /> Modified: /
> /> /trunk/src/TortoiseProc/ProjectProperties.cpp /
> /> /
> /> ======================================= /
> /> --- /trunk/src/TortoiseProc/ProjectProperties.cpp Sat Feb 5
> 16:35:57 2011 /
> /> +++ /trunk/src/TortoiseProc/ProjectProperties.cpp Fri Feb 11
> 20:46:51 2011 /
> /> @@ -810,14 +810,16 @@ /
> /> } /
> /> sRet.Trim(); /
> /> /
> /> - if (sRet.IsEmpty()) /
> /> - return sMessage; /
> /> - /
> /> return sRet; /
>
> Not sure why you removed that, but it's required. I added it back in
> r20854.
>
Well, according to the docstring, these lines should be removed.
If there is no match, an empty string must be returned.

This function will only be called from MakeShortMessage() which
will not fall back to its shortening logic unless GetLogSummary()
returns an empty string.

-- Stefan^2.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2703658

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-02-13 14:57:33 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.