[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch - code duplication and no quotes around path to executable in LogDlg

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 25 Jan 2011 20:21:07 +0100

On 25.01.2011 08:25, Dmitry wrote:
> Hey.
>
> Attached is an untested patch that addresses - code duplication -
> lack of quotes around the filepath in some calls to
> "LaunchApplication" in LogDlg.

Committed in r20765.

> Btw do you have any idea of why it would work without quotes even
> when Tortoise SVN is installed into a subfolder of "c:\program files"
> (a path with a whitespace)? I've never seen any problem so far.

Strange. That shouldn't have worked. But I tested it, and strangely
TortoiseProc was started without problems even though the path had a
space in it.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2700414
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-01-25 20:21:30 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.