Patch - leaking file handles and minor issues in ContextMenu

From: Dmitry <wipedout_at_yandex.ru>
Date: Tue, 25 Jan 2011 13:16:50 +0300

Hey.

CShellExt::WriteClipboardPathsToTempFile() leaks file handles on edge cases and also has
- too wide scope of variables
- unused variable
- unneeded extra copying of string

Attached is an untested patch that addresses that.

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2700339

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

application/octet-stream attachment: Patch_-_LeakingFileHandles.patch

Received on 2011-01-25 11:17:04 CET

This message: [ Message body ]
Next message: Stefan Küng: "Re: Patch - code duplication and no quotes around path to executable in LogDlg"
Previous message: Dmitry: "Patch - code duplication and no quotes around path to executable in LogDlg"
Next in thread: Stefan Küng: "Re: Patch - leaking file handles and minor issues in ContextMenu"
Reply: Stefan Küng: "Re: Patch - leaking file handles and minor issues in ContextMenu"

Contemporary messages sorted: [ by date ] [ by thread ] [ by subject ] [ by author ] [ by messages with attachments ]