Re: Suspicious code in AppUtils

On 21.01.2011 08:00, Dmitry wrote:
> Hey.
>
> Currently CAppUtils::StartExtMerge() contains the following code:
>
> com = CPathUtils::GetAppDirectory() + _T("TortoiseMerge.exe"); if
> (com.IsEmpty()) { com = CPathUtils::GetAppDirectory(); com +=
> _T("TortoiseMerge.exe"); }
>
> which looks insane. First, how could a concatenation of anything with
> a non-empty string literal produce an empty string? Second, even if
> that happens why compute and assign the very same concatenation
> again?

You're right of course. That code seems to be some leftover from a
previous change.
Removed in r20744.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2699661
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].