Re: Suspicious code in AppUtils

On 1/21/2011 12:00 AM, Dmitry wrote:
> Hey.
>
> Currently CAppUtils::StartExtMerge() contains the following code:
>
> com = CPathUtils::GetAppDirectory() + _T("TortoiseMerge.exe");
> if (com.IsEmpty())
> {
> com = CPathUtils::GetAppDirectory();
> com += _T("TortoiseMerge.exe");
> }
>
> which looks insane. First, how could a concatenation of anything with a non-empty string literal produce an empty string? Second, even if that happens why compute and assign the very same concatenation again?
>
> Best wishes.
> Dmitry.

I just want to say that you are awesome because you are a fresh set of
eyes on this codebase. You are scouring it and taking a serious look at
it. Most people install and don't bother to look at the source code or
are the developers who are in among the trees and can't see the forest
as a result - this just happens naturally because people are busy.
Fresh eyes + dedication to quality = a great thing.

-- 
Thomas Hruska
CubicleSoft President
Barebones CMS is a high-performance, open source content management 
system for web developers operating in a team environment.
An open source CubicleSoft initiative.
Your choice of a MIT or LGPL license.
http://barebonescms.com/
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2699653
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].